-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace lazy_static with once_cell #133
Conversation
As long as |
Hi I don't get why we should remove Without good reason, I would prefer to do nothing and close this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain why we should do this change
I do think The only logic for it being a breaking change (from what I've seen) is that the static implements |
The ecosystem has been migrating from My main motivation as hinted in the PR description is keeping the dependency tree small where possible. I don't know how important the |
744b5dd
to
1921f20
Compare
Sorry to just now mention this @Lonami, but it looks like #119 is doing the same thing, and I'd probably accept that one just because the PR was made first. If you'd want to make a PR for that |
If you think this one merits enough to get merged in still I'd be fine reopening it though, just let me know. |
I was unaware the other PR existed. I had trouble running But ultimately I don't really care how it's done, as long as it gets merged eventually. I'll subscribe to the other PR instead. Thanks! |
Yeah I'm not sure why the section in |
This should make it easier for the ecosystem to trim down the dependency tree.
I didn't update
rspec
to the1.0
version because it seemed to pull a bunch other things and is only used in dev mode.I think this is technically a breaking change, so let me know if we should bump the version number to 0.4.