Create image workflow #345
Conversation
There was a problem hiding this comment.
I think this workflow is duplicating the work of ci-build.yml, with the additional step (the only difference?) for uploading an image to GH's Docker registry.
From what I understood, the image will be built for each change done to the main branch. But the image won't have the commit hash, instead if will use the date of the job that generated the change.
I think instead we could:
- push the image manually when necessary specifying the version?
- or push it with the commit hash instead of the date only? Or a combination of both?
- remove the duplicated build process, and build this one only if the build has succeeded? (I think that's doable in GH actions)
workflow now runs only if CWL Viewer Build workflow completes
| DATE=$(date +%s) | ||
| GIT_HASH=$(git rev-parse --short "$GITHUB_SHA") | ||
| VERSION= ${GIT_HASH}-${DATE} | ||
| docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} -p ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | ||
| docker build . --file Dockerfile --tag ${{ secrets.DOCKER_HUB_USERNAME }}/cwlviewer:${VERSION} | ||
| docker push ${{ secrets.DOCKER_HUB_USERNAME }}/cwlviewer:${VERSION} |
There was a problem hiding this comment.
Can you review https://github.com/common-workflow-language/cwlviewer/pull/360/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R216 and incorporate the process documented there?
There was a problem hiding this comment.
@obasekiosa let me know if you have questions
There was a problem hiding this comment.
specifically, I would like this to match the tagging conventions and the --build-arg calls (lines 222 - 227) of https://github.com/common-workflow-language/cwlviewer/pull/360/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R216
There was a problem hiding this comment.
Nothing to add besides +1 on @mr-c 's comment about re-using the build instructions linked. Great job @obasekiosa !
|
@obasekiosa I see that this workflow is hard to test in a PR. Drop a link here to the working run on your fork, along with a link to the resulting container on your Docker Hub or quay.io account. Of course, let me know if you have any questions, we can even have a voice chat with screen sharing to troubleshoot any problems that arise. |
| run: | | ||
| DATE=$(date +%s) | ||
| GIT_HASH=$(git rev-parse --short "$GITHUB_SHA") | ||
| VERSION= ${GIT_HASH}-${DATE} |
There was a problem hiding this comment.
| VERSION= ${GIT_HASH}-${DATE} | |
| VERSION=${GIT_HASH}-${DATE} |
Description
Adds a GitHub action that builds and pushes a docker image of the repository to docker hub
images are tagged with docker_username/repo_name:date
Motivation and Context
This allows for the first step in the CD process.
fixes #306
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: