-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cpp gen storing yaml #900
Merged
mr-c
merged 16 commits into
common-workflow-language:main
from
SGSSGene:fix/cpp-gen_storing_yaml
Dec 19, 2024
Merged
Fix/cpp gen storing yaml #900
mr-c
merged 16 commits into
common-workflow-language:main
from
SGSSGene:fix/cpp-gen_storing_yaml
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now properly reads 'jsonldPredicate' and repsects the 'mapSubject', 'mapPredicate' and 'typeDSL' fields.
SGSSGene
force-pushed
the
fix/cpp-gen_storing_yaml
branch
from
December 16, 2024 07:55
6c6c443
to
1bb72ee
Compare
SGSSGene
force-pushed
the
fix/cpp-gen_storing_yaml
branch
from
December 16, 2024 08:10
ed32cbb
to
5975cb0
Compare
SGSSGene
force-pushed
the
fix/cpp-gen_storing_yaml
branch
from
December 16, 2024 09:47
5975cb0
to
1f66ad8
Compare
SGSSGene
force-pushed
the
fix/cpp-gen_storing_yaml
branch
from
December 18, 2024 07:19
1f66ad8
to
710eaac
Compare
SGSSGene
force-pushed
the
fix/cpp-gen_storing_yaml
branch
from
December 18, 2024 07:38
859fe2e
to
d8d734d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
+ Coverage 83.13% 83.29% +0.15%
==========================================
Files 22 22
Lines 4899 4944 +45
Branches 1177 1182 +5
==========================================
+ Hits 4073 4118 +45
Misses 548 548
Partials 278 278 ☔ View full report in Codecov by Sentry. |
SGSSGene
force-pushed
the
fix/cpp-gen_storing_yaml
branch
from
December 18, 2024 08:25
920e317
to
5ef98ca
Compare
mr-c
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple concerns at once:
typeDSL
optionmapPredicate
when doing map ⇔ list conversions. (and not onlymapSubject
)DocumentRootType
type andload_document
andstore_document
functions.store_config
object, which allows to control simplification of types, list to map conversion and partial YAML-tag output (all very helpful when debugging).cpp_gen
namespace to avoid symbol spilling into other parts of c++ programs.A basic program that can load and save(print) CWL tool description files (or any
DocumentRootType
type):