Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action to check metadata lines in scripts. #1110

Merged

Conversation

quantumryuu
Copy link
Contributor

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Github action to check the following:

  • # Copyright (c) 2021-2024 community-scripts ORG
    Check if it exists in line 3
  • # Author: [Name] (also checks if there is text after the space"
    Check if it exists in line 4 & that it has text after the space
  • # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
    Check if it exists in line 5
  • # Source: [Source] (also checks if there is text after the space"
    Check if it exists in line 6 & that it has text after the space

Please remove unneeded lines!


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@quantumryuu quantumryuu requested a review from a team as a code owner December 30, 2024 12:18
@github-actions github-actions bot added the maintenance Code maintenance or general upkeep of the project label Dec 30, 2024
MickLesk
MickLesk previously approved these changes Dec 30, 2024
.github/workflows/check-metadata.yml Outdated Show resolved Hide resolved
.github/workflows/check-metadata.yml Outdated Show resolved Hide resolved
.github/workflows/check-metadata.yml Show resolved Hide resolved
.github/workflows/check-metadata.yml Show resolved Hide resolved
@MickLesk MickLesk merged commit 682087c into community-scripts:main Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code maintenance or general upkeep of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants