Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: Pf2eTools #1162

Merged
merged 17 commits into from
Jan 2, 2025
Merged

Conversation

TheRealVira
Copy link
Contributor

✍️ Description

Created new scripts for Pf2eTools wiki.


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

@TheRealVira TheRealVira requested a review from a team as a code owner January 1, 2025 18:08
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Jan 1, 2025
ct/Pf2eTools.sh Outdated Show resolved Hide resolved
install/Pf2eTools-install.sh Outdated Show resolved Hide resolved
@TheRealVira
Copy link
Contributor Author

It's now ready for merge.

@MickLesk
Copy link
Member

MickLesk commented Jan 1, 2025

Quick question, I was just wondering why the 2 scripts? They are neither in discussions nor in the project pipeline. I'll let it go this time, but not later. The project pipeline should be adhered to. There are some in Ready to picked up

(20 in ready):
https://github.com/orgs/community-scripts/projects/9/views/1

@TheRealVira
Copy link
Contributor Author

To be honest, I was working on migrating 5etools, pf2etools and mealie for my own setup. I want to give back to the community so I thought that it would be best to make my scripts public. I don't mean to break any guidelines or anything, I just look forward to sharing my scripts.

@MickLesk
Copy link
Member

MickLesk commented Jan 1, 2025

All right, I've invited you to the Scripters Team.

Then next time please add a script in “Ready” (in project pipeline), create an issue from it, move it to Progress and as soon as there is a PR, move it to PR State.
(You have to assign yourself once everywhere, so that nothing is done twice or similar), Mealie was actually planned with @dsiebel, but I think he won't mind ^^

@TheRealVira
Copy link
Contributor Author

I am also fine not doing mealie, or doing it together with @dsiebel 👍
Whatever is fine for me tbh

@MickLesk MickLesk merged commit e356259 into community-scripts:main Jan 2, 2025
4 checks passed
MickLesk added a commit that referenced this pull request Jan 2, 2025
* Testing 5etools.

* Introducing Pf2eTools

* Replacing name with var.

* Switched to release crawling.

* Re-added git.

* Update Pf2eTools-install.sh

* Update Pf2eTools-install.sh

* Update Pf2eTools-install.sh

* Update Pf2eTools.sh

* Update Pf2eTools-install.sh

* Update Pf2eTools.sh

* Update Pf2eTools.sh

* Update Pf2eTools-install.sh

* Update Pf2eTools.sh

* Update Pf2eTools-install.sh

* Update Pf2eTools.sh

Fix update script

* Update Pf2eTools.json

---------

Co-authored-by: CanbiZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants