Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of etcd-cpp-apiv3 #22596

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Jan 30, 2024

Specify library name and version: etcd-cpp-apiv3/0.15.4


@AndreyMlashkin AndreyMlashkin force-pushed the etcd-cpp-apiv3/initial-implementation branch from 337a73b to 90a2ec1 Compare January 30, 2024 17:57
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

@uilianries @SSE4
I don't have these issues.
I have implemented deleting cmake files:
rmdir(self, os.path.join(self.package_folder, "lib", "cmake"))

And I have also marked cpprestsdk as transitive

@uilianries uilianries self-assigned this Feb 5, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreyMlashkin Thank you for reporting that error. It's an outdated output, I tested your PR locally there is no such error. So, I just restart its build.

Please, always ping @conan-io/barbarians as described #22596 (comment). It will ping Conan team members directly, instead only few.

recipes/etcd-cpp-apiv3/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Feb 5, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Feb 6, 2024
@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

AndreyMlashkin commented Feb 6, 2024

Screenshot from 2024-02-06 09-44-01
Another CI bug?
It says, .github/workflows/stale.yml was changed, but it's not in the list of changed files

@conan-io/barbarians

@uilianries
Copy link
Member

Screenshot from 2024-02-06 09-44-01 Another CI bug? It says, .github/workflows/stale.yml was changed, but it's not in the list of changed files

@conan-io/barbarians

@AndreyMlashkin it's fixed now. Thank you for pinging, I just restarted this PR.

@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Copy link
Member

@AndreyMlashkin Please, consider the PR AndreyMlashkin#11 as my review. It contains several suggestions related to this PR.

…ntation

[etcd-cpp-apiv3] Review changes for CCI
@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Feb 6, 2024
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

uilianries commented Feb 6, 2024

ERROR: Missing prebuilt package for 'openssl/3.2.1'

I just started an internal CI build to generate the missing package.

The build result should be available at https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/prod-v1/TapaholesRepo/141/summary.json as soon as finished.

@uilianries
Copy link
Member

I just restarted the PR now. OpenSSL has been generated.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

Started another internal build to generate the missing cpprestsdk/2.10.19

@AndreyMlashkin
Copy link
Contributor Author

Started another internal build to generate the missing cpprestsdk/2.10.19

will the build automatically restarted or should I restart it after some time?

@uilianries
Copy link
Member

will the build automatically restarted or should I restart it after some time?

It's automated, don't worry. Yesterday, Jenkins was under maintenance as scheduled and discussed here: #20497

This PR should be running soon.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Feb 8, 2024
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

uilianries commented Feb 8, 2024

Hmm, the project uses abseil which requires C++14. This project is real flexible in terms of standard, so we need to require C++14 as well.

Signed-off-by: Uilian Ries <[email protected]>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 16 (84727a597aff37435602d68e8df19075feb6c7f6):

  • etcd-cpp-apiv3/0.15.4:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 16 (84727a597aff37435602d68e8df19075feb6c7f6):

  • etcd-cpp-apiv3/0.15.4:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 8606c23 into conan-io:master Feb 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants