-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation of etcd-cpp-apiv3 #22596
initial implementation of etcd-cpp-apiv3 #22596
Conversation
337a73b
to
90a2ec1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@uilianries @SSE4 And I have also marked cpprestsdk as transitive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreyMlashkin Thank you for reporting that error. It's an outdated output, I tested your PR locally there is no such error. So, I just restart its build.
Please, always ping @conan-io/barbarians
as described #22596 (comment). It will ping Conan team members directly, instead only few.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@AndreyMlashkin it's fixed now. Thank you for pinging, I just restarted this PR. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
@AndreyMlashkin Please, consider the PR AndreyMlashkin#11 as my review. It contains several suggestions related to this PR. |
…ntation [etcd-cpp-apiv3] Review changes for CCI
This comment has been minimized.
This comment has been minimized.
I just started an internal CI build to generate the missing package. The build result should be available at https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/prod-v1/TapaholesRepo/141/summary.json as soon as finished. |
I just restarted the PR now. OpenSSL has been generated. |
This comment has been minimized.
This comment has been minimized.
Started another internal build to generate the missing |
will the build automatically restarted or should I restart it after some time? |
It's automated, don't worry. Yesterday, Jenkins was under maintenance as scheduled and discussed here: #20497 This PR should be running soon. |
This comment has been minimized.
This comment has been minimized.
Hmm, the project uses abseil which requires C++14. This project is real flexible in terms of standard, so we need to require C++14 as well. |
Signed-off-by: Uilian Ries <[email protected]>
Conan v1 pipeline ✔️All green in build 16 (
Conan v2 pipeline ✔️
All green in build 16 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Specify library name and version: etcd-cpp-apiv3/0.15.4