Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opendis6] new recipe #22646

Merged
merged 23 commits into from
Feb 8, 2024
Merged

[opendis6] new recipe #22646

merged 23 commits into from
Feb 8, 2024

Conversation

crhowell3
Copy link
Contributor

Specify library name and version: opendis6/0.1.0

I am the author of this library. It is a modern C++ implementation of IEEE 1278.1a-1998 (DIS v6).


@CLAassistant
Copy link

CLAassistant commented Feb 3, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

2 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@crhowell3 crhowell3 marked this pull request as ready for review February 5, 2024 17:55
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Feb 6, 2024
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Copy link
Member

@crhowell3 Thank you for your contribution, please, consider the PR https://github.com/crhowell3/conan-center-index/pull/1 as my review and improvement to this PR.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Hooks produced the following warnings for commit 4c5032e
opendis6/0.1.0@#f7344124da7f6c754d6a1f361fa6aa39
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libOpenDIS6.so' links to system library 'm' but it is not in cpp_info.system_libs.

@crhowell3
Copy link
Contributor Author

crhowell3 commented Feb 6, 2024

This should be good for review and merge👍🏻

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Feb 7, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Hooks produced the following warnings for commit d941a57
opendis6/0.1.0@#a92fa278752c371b0bd5fddda82c2f51
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libOpenDIS6.so' links to system library 'm' but it is not in cpp_info.system_libs.

AbrilRBS
AbrilRBS previously approved these changes Feb 7, 2024
recipes/opendis6/all/conanfile.py Outdated Show resolved Hide resolved
recipes/opendis6/all/conanfile.py Outdated Show resolved Hide resolved
@AbrilRBS AbrilRBS dismissed stale reviews from uilianries and themself via 2f4149c February 7, 2024 10:36
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, we appreciate it, I've pushed the last final changes to get this merged :)

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 22 (bc3c2b858f9b40def720a6d4c14a0da937e3e992):

  • opendis6/0.1.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 7ed79e4 into conan-io:master Feb 8, 2024
13 checks passed
@crhowell3 crhowell3 deleted the opendis6-0.1.0 branch February 8, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants