-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new recipe for melon/1.0.0-alpha.1 #25189
new recipe for melon/1.0.0-alpha.1 #25189
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fhamonic thanks a lot for taking the time to create this PR, we appreciate it! I have a few minor comments, but overall this looks great! :)
recipes/melon/all/conanfile.py
Outdated
# Set these to the appropriate values if the package has an official FindPACKAGE.cmake | ||
# listed in https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html#find-modules | ||
# examples: bzip2, freetype, gdal, icu, libcurl, libjpeg, libpng, libtiff, openssl, sqlite3, zlib... | ||
# self.cpp_info.set_property("cmake_module_file_name", "melon") | ||
# self.cpp_info.set_property("cmake_module_target_name", "melon::melon") | ||
|
||
# Set these to the appropriate values if package provides a CMake config file | ||
# (package-config.cmake or packageConfig.cmake, with package::package target, usually installed in <prefix>/lib/cmake/<package>/) | ||
# self.cpp_info.set_property("cmake_file_name", "melon") | ||
# self.cpp_info.set_property("cmake_target_name", "melon::melon") | ||
# Set this to the appropriate value if the package provides a pkgconfig file | ||
# (package.pc, usually installed in <prefix>/lib/pkgconfig/) | ||
# self.cpp_info.set_property("pkg_config_name", "melon") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to remove these lines, alongside the rest of the comments from the template :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@@ -0,0 +1,4 @@ | |||
sources: | |||
"1.0.0-alpha.1": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have an idea on when proper 1.0.0
would be released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, algorithms are well tested but I feel like the library lacks some features like serialization/visualization to be complete. I have been asked to submit a recipe and I think that making the library available on Conan-center could stimulate potential feedback and maybe contributions for designing these features.
Given that this is an important project for me, I'll continue working on it for sure :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to hear! Thanks for the extra insight
Hi @AbrilRBS, thanks for taking the time to review this recipe and thanks for your comments! |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pinned the dependencies versions, as those are not quite ready to be used as version ranges yet, sorry for the confussion!
Otherwise, this looks great now, thanks a lot for taking the time to get the PR thru to the finish line, we appreciate it :)
@@ -0,0 +1,4 @@ | |||
sources: | |||
"1.0.0-alpha.1": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to hear! Thanks for the extra insight
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot for contributing to conan! And the library looks promising!
It would be great to add some conan instructions to your repo README!
Something similar to: https://github.com/jlblancoc/nanoflann#using-conan 🚀
* new recipe for melon/1.0.0-alpha.1 * fixed url in conanfile.py * removed unecessary stuff in conanfile.py + improved test_package * Cleanup, pin dependencies --------- Co-authored-by: Abril Rincón Blanco <[email protected]>
Summary
Changes to recipe: melon/1.0.0-alpha.1
Motivation
Add melon, a C++20 high performance graph library.
Details
https://github.com/fhamonic/melon