Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new recipe for melon/1.0.0-alpha.1 #25189

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

fhamonic
Copy link
Contributor

@fhamonic fhamonic commented Sep 9, 2024

Summary

Changes to recipe: melon/1.0.0-alpha.1

Motivation

Add melon, a C++20 high performance graph library.

Details

https://github.com/fhamonic/melon


@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fhamonic thanks a lot for taking the time to create this PR, we appreciate it! I have a few minor comments, but overall this looks great! :)

recipes/melon/all/conanfile.py Outdated Show resolved Hide resolved
recipes/melon/all/conanfile.py Outdated Show resolved Hide resolved
Comment on lines 101 to 113
# Set these to the appropriate values if the package has an official FindPACKAGE.cmake
# listed in https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html#find-modules
# examples: bzip2, freetype, gdal, icu, libcurl, libjpeg, libpng, libtiff, openssl, sqlite3, zlib...
# self.cpp_info.set_property("cmake_module_file_name", "melon")
# self.cpp_info.set_property("cmake_module_target_name", "melon::melon")

# Set these to the appropriate values if package provides a CMake config file
# (package-config.cmake or packageConfig.cmake, with package::package target, usually installed in <prefix>/lib/cmake/<package>/)
# self.cpp_info.set_property("cmake_file_name", "melon")
# self.cpp_info.set_property("cmake_target_name", "melon::melon")
# Set this to the appropriate value if the package provides a pkgconfig file
# (package.pc, usually installed in <prefix>/lib/pkgconfig/)
# self.cpp_info.set_property("pkg_config_name", "melon")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to remove these lines, alongside the rest of the comments from the template :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@@ -0,0 +1,4 @@
sources:
"1.0.0-alpha.1":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an idea on when proper 1.0.0 would be released?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, algorithms are well tested but I feel like the library lacks some features like serialization/visualization to be complete. I have been asked to submit a recipe and I think that making the library available on Conan-center could stimulate potential feedback and maybe contributions for designing these features.
Given that this is an important project for me, I'll continue working on it for sure :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to hear! Thanks for the extra insight

@AbrilRBS AbrilRBS self-assigned this Sep 12, 2024
@fhamonic
Copy link
Contributor Author

Hi @AbrilRBS, thanks for taking the time to review this recipe and thanks for your comments!
I've done the modifications and pushed :)

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pinned the dependencies versions, as those are not quite ready to be used as version ranges yet, sorry for the confussion!

Otherwise, this looks great now, thanks a lot for taking the time to get the PR thru to the finish line, we appreciate it :)

@@ -0,0 +1,4 @@
sources:
"1.0.0-alpha.1":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to hear! Thanks for the extra insight

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (45111c259f8be8264769d4174e9faa7bb1a7a9f7):

  • melon/1.0.0-alpha.1:
    No packages built ⚠️ (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (45111c259f8be8264769d4174e9faa7bb1a7a9f7):

  • melon/1.0.0-alpha.1:
    Built 1 packages out of 5 (All logs)

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for contributing to conan! And the library looks promising!
It would be great to add some conan instructions to your repo README!
Something similar to: https://github.com/jlblancoc/nanoflann#using-conan 🚀

@conan-center-bot conan-center-bot merged commit 856f4e9 into conan-io:master Sep 16, 2024
12 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
* new recipe for melon/1.0.0-alpha.1

* fixed url in conanfile.py

* removed unecessary stuff in conanfile.py + improved test_package

* Cleanup, pin dependencies

---------

Co-authored-by: Abril Rincón Blanco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants