[linter] Simplify Conan V2 migration linter #25323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
AbrilRBS
approved these changes
Sep 19, 2024
danimtb
approved these changes
Sep 19, 2024
|
I'm seeing many false positives in #25325 and other PRs. 🙁 |
3 tasks
OMGtechy
pushed a commit
to OMGtechy/conan-center-index
that referenced
this pull request
Dec 31, 2024
* Remove check Conans import Signed-off-by: Uilian Ries <[email protected]> * Remove check conans import Signed-off-by: Uilian Ries <[email protected]> * Remove lower case name check Signed-off-by: Uilian Ries <[email protected]> * Use Conan 2.x for transition linter Signed-off-by: Uilian Ries <[email protected]> * Remove old linters from linters doc Signed-off-by: Uilian Ries <[email protected]> * Conan 2.x is mandatory Signed-off-by: Uilian Ries <[email protected]> --------- Signed-off-by: Uilian Ries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: lib/[version]
Motivation
The PR #25319 is failing due Conan V2 linter migration. The Conan 2.x was released 19 months ago and mostly of CCI is ported now.
Some lints are outdated and may not be needed anymore as Conan 2.x build is mandatory. For instance, Conan 2.x only accepts lowe-case package names by default.
Details
I also installed Conan 2.x instead of Conan 1.x to run the linter, so we can skip errors like showed on #25319.