Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added extra-cmake-modules 6.8.0 #26236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boussaffawalid
Copy link
Contributor

Summary

Changes to recipe: extra-cmake-modules/6.8.0

Motivation

added new version


@jcar87
Copy link
Contributor

jcar87 commented Dec 30, 2024

Thanks @boussaffawalid !

can't find a motivation or description for the patches/0001-fix-find_package-qt.patch patch - please ensure there's sufficient information in the PR description so that we can review this, thanks!

@boussaffawalid
Copy link
Contributor Author

@jcar87 conan's qt package does not define config file for each qt component, also _FOUND are not defined.

For example:

  • find_package(Qt6Core) does not work with conan, and therefore I had to change it to find_package(Qt6 COMPONENTS Core)
  • Qt5Core_FOUND is not defined by conan, and I had to change it to if (TARGET Qt5::Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants