Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiprocess v0.70.17 #51

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11116961488 - please use this URL for debugging.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@synapticarbors
Copy link
Member

Looks like this is failing due to pypa/pip#12884

@synapticarbors
Copy link
Member

Solution on some feedstocks is to pin pip <24.2

@thewchan
Copy link
Contributor

@synapticarbors @jschueller Any update on this one? I have one downstream that depends on this. Thanks!

@synapticarbors
Copy link
Member

@conda-forge-admin please rerender

@synapticarbors synapticarbors added the automerge Merge the PR when CI passes label Oct 26, 2024
@synapticarbors
Copy link
Member

@conda-forge/core I'm seeing a permission denied error after re-rendering on all builds. For example on linux:

/home/vsts/work/_temp/cb04ad42-87db-4915-a95c-a785eab82003.sh: line 12: .scripts/run_docker_build.sh: Permission denied

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1065393&view=logs&j=5eaeabf9-98bb-5ad4-ae9b-9c34ad8b134f&t=ef28f095-7a97-583f-1501-aab4442be48f&l=12

@thewchan
Copy link
Contributor

@synapticarbors I've seen this elsewhere; I was able to fix this in other feedstocks by pulling to local, rerendering there, and pushing back to remote.

CC: @conda-forge/core We're still seeing this permission error in the CI periodically

Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@synapticarbors
Copy link
Member

@thewchan -- Thanks. Let me give that a try.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Oct 26, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@synapticarbors synapticarbors added the automerge Merge the PR when CI passes label Oct 26, 2024
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Oct 26, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@synapticarbors synapticarbors merged commit 30b5d56 into conda-forge:main Oct 27, 2024
33 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.70.17_h1b805e branch October 27, 2024 00:30
@bollwyvl
Copy link

I think the pip check issue may be indicative of something real: downstream on conda-forge/schedula-feedstock#79, i could only get the test suite running by pinning to !=0.70.17.

@thewchan
Copy link
Contributor

thewchan commented Nov 1, 2024

I'm getting something strange downstream:

multiprocess 0.70.17 is not supported on this platform

E.g. here: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1068968&view=logs&j=d818e662-7181-5ce9-b265-50d03742b7af&t=367317f3-9b77-59ac-9e12-e56370c98acd&l=1069

Might be similar problems @bollwyvl is seeing. CC: @synapticarbors

@thewchan
Copy link
Contributor

Also here: conda-forge/pyina-feedstock#8

@hmaarrfk
Copy link

Was it really necessary to skip the pip check test in this way?

Pip check is now relied on in many recipes and i don't think it is ok to simply drop it like this for conda-forge.

@thewchan
Copy link
Contributor

@hmaarrfk see: #52

Somehow pip check working with python 3.13 but failing on all lower

@thewchan
Copy link
Contributor

thewchan commented Nov 15, 2024

okay I think it has to do with this: uqfoundation/multiprocess#196

Looks like upstream is planning to release a 0.70.17.1 to fix

@bollwyvl
Copy link

bollwyvl commented Nov 15, 2024 via email

@thewchan
Copy link
Contributor

Here's the fix someone is proposing upstream: uqfoundation/multiprocess#197

Seems more than a 1 liner and it's trying to future proof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants