-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pelican-bibliography. #18690
Added pelican-bibliography. #18690
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I need to delete the pyproject.toml file for this windows build also. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pelican-bibliography:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pelican-bibliography:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python this is ready for review. I couldn't figure out how to handle the pyproject.toml file (as usual!). I'll convert this to a noarch build once the feedstock is created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project uses both poetry
and setuptools
in its build system. Did you try adding poetry
to the host section of the recipe?
No, I am not really familiar with poetry. I thought it was an end user's optional tool for installing and managing virtual environments. I've always thought that |
These are relevant issues: conda-forge/conda-forge.github.io#1174 conda-forge/conda-forge.github.io#1540 that explain the complications of the pyproject.toml file (which maybe that is tied to poetry?) |
Another related issue, is that the dependency pins in that toml file are very restrictive and if used as is, would make this package difficult to install alongside a large number of packages in a conda environment. I've elected to not include upper bounds on the pins for the conda package to ease the work of the conda sat solver. |
OK, but if you look at the build logs, it tells you that it needs poetry.
Yes, but as you noted in the linked issues, the python ecosystem is moving away from In the PR you linked, the preferred method for dealing with this problem is adding
Which you did try, but you didn't add poetry to the host requirements. So please try the out of tree build whilst also installing poetry. |
Sure, I can try more things. I've tried lots of things over the past year+ and haven't landed on a consistently functioning solution other than deleting the toml files. |
…ecipes into pelican-bibliography
The windows build failed with:
Maybe there's a unicode character in a path? |
On the bright side the unix builds succeeded, so we're kinda just back where we were just with a different error. 😄 |
The other bright side is that this error from the Windows build is coming from trying to install @conda-forge/pelican and not coming from the package in this recipe. I was able to recreate this problem on my Windows machine with just trying to install |
Related: conda/conda-build#4043 It seems like conda just isn't good at handling unicode paths on Windows. |
@moorepants, I believe this situation is summarized as "the package does not install on windows because a dependency is broken", so I will merge this PR and you will have to decide if you want to chase down the solution for pelican's broken install on Windows. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).