Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Batchgenerators #28390

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Add Batchgenerators #28390

merged 3 commits into from
Nov 28, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Nov 28, 2024 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/batchgenerators/meta.yaml) and found it was in an excellent condition.

@jan-janssen
Copy link
Member Author

@conda-forge/staged-recipes, ready for review

@github-actions GitHub Actions
Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@jan-janssen
Copy link
Member Author

@conda-forge/help-python

jan-janssen
jan-janssen commented Nov 28, 2024
View reviewed changes
recipes/batchgenerators/python3.patch
"scikit-learn",
"future",
"pandas",
- "unittest2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are currently discussed in a pull request up-stream MIC-DKFZ/batchgenerators#130 beyond other things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add that link and comment in the recipe? It will be easier to find them there than in this PR when we need it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf Sure - done

@ocefpaf ocefpaf merged commit 102c617 into conda-forge:main Nov 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf left review comments

Assignees
No one assigned
Labels
python review-requested staged-recipes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jan-janssen @conda-forge-admin @ocefpaf