Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Avoid ESMPy 8.4.* #44

Closed
wants to merge 3 commits into from
Closed

DEP: Avoid ESMPy 8.4.* #44

wants to merge 3 commits into from

Conversation

DWesl
Copy link

@DWesl DWesl commented Oct 31, 2024

ESMPy 8.4.* imports only with old versions of importlib_metadata. With current versions of importlib_metadata, ESMPy fails to import.

Closes #43

Checklist

DWesl added 2 commits October 31, 2024 10:16
ESMPy 8.4.* imports only with old versions of importlib_metadata.
With current versions of importlib_metadata, ESMPy fails to import.

Closes conda-forge#43
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11613907620.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11613922222.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11613927470.

@aulemahal
Copy link
Contributor

Two notes:

  • esmf 8.4 is the last version available to windows users. This PR means that windows users will be stuck with <= 8.3 for the next xESMF releases. I'm not sure of the implications though...

  • Looks like the latest xarray causes some problems with xESMF... I'll look into that.

@aulemahal
Copy link
Contributor

I opened a PR for the xarray issue : pangeo-data/xESMF#395

@ocefpaf, I'm not familiar enough with conda packaging:

  • Would it be a good idea to pin xarray here. A subsequent release of xESMF 0.8.8 would unpin it. Or should we just wait and release 0.8.8 as soon as possible ?
  • Can we make the ESMpy pins condition on importlib_metadata's version or something like that ? The issue is that 8.4 is the most recent version windows users can use.

@ocefpaf
Copy link
Member

ocefpaf commented Oct 31, 2024

  • Would it be a good idea to pin xarray here. A subsequent release of xESMF 0.8.8 would unpin it. Or should we just wait and release 0.8.8 as soon as possible ?

Yes. That or backport that PR as a patch.

Can we make the ESMpy pins condition on importlib_metadata's version or something like that ? The issue is that 8.4 is the most recent version windows users can use.

Not sure what you mean but if I got it right it will be inconsistent where Windows will be allowed to get the reversion you want to avoid but the other platforms won't. Why is that? What is broken in 8.4 ?

@aulemahal
Copy link
Contributor

aulemahal commented Oct 31, 2024

it will be inconsistent

I was more thinking of a pin on importlib_metadata which would give a way for windows users to still have consistent envs with 8.4. If we continue as in this PR, it is simply forbidden. The issue with windows is because the conda builds of ESMF broke in 8.5 and devs there have not yet been able to fix them.

@ocefpaf
Copy link
Member

ocefpaf commented Nov 1, 2024

I was more thinking of a pin on importlib_metadata which would give a way for windows users to still have consistent envs with 8.4.

I'm not following. Conda doesn't rely on importlib_metadata to solve envs. How will thy be inconsistent?

@aulemahal
Copy link
Contributor

I'm referring to the issue #43. And you know what, windows users will simply have to install previous versions of xesmf if they want esmf 8.4. I do not have the time and energy to solve this in a fancy way.

@aulemahal
Copy link
Contributor

I just released xESMF 0.8.8, I will merge the changes from this branch into the branch updating the conda pacakge.

@aulemahal aulemahal closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xESMF can pull in unimportable ESMPy 8.4.* as dependency
4 participants