Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow remote .conda artifact listing #254

Merged
merged 13 commits into from
Jul 18, 2024
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jul 1, 2024

Description

Closes #252

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 1, 2024
@jaimergp
Copy link
Contributor Author

jaimergp commented Jul 1, 2024

pre-commit.ci autofix

@jezdez jezdez requested a review from dholth July 8, 2024 14:03
@@ -82,3 +82,27 @@ def test_list(artifact, n_files, capsys):

with pytest.raises(ValueError):
cli.main(["list", "setup.py"])


@pytest.mark.parametrize(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several other conda projects including conda, conda-index, conda-package-streaming, use local web servers as a CI fixture for this sort of thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bottle fixture similar to what CPS is doing (but supported by pytest-xprocess for simplicity).

@jaimergp
Copy link
Contributor Author

@JeanChristopheMorinPerso do you want to give this PR a try? I think it should solve your use case (with some limitations in -v mode, but that's all we can do with the available metadata 😬)

@JeanChristopheMorinPerso

@jaimergp it seems to work, thanks!

Can I suggest to change the help message to mention URL too?

(test) jcmorin-mac-anac:aggregate jcmorin$ cph list --help
usage: cph list [-h] [-v] [--components COMPONENTS] archive_path

positional arguments:
  archive_path          path or URL to archive to inspect

?

@jaimergp
Copy link
Contributor Author

Good catch. Added!

@travishathaway travishathaway merged commit 1840d98 into conda:main Jul 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

cph list a remote package?
5 participants