FIX - Dynamic Fork (workflow as code) #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… forces the user to pass a "pre_fork_task" from which the dynamic tasks and inputs are going to be taken from. But, it's not working + it's rigid. It won't allow using an INLINE task for example (given how this task outputs the result), it won't allow to hardcode the dynamic inputs in the task def itself, or take it from a workflow input.
jmigueprieto
commented
Jan 14, 2025
jmigueprieto
changed the title
c4lm
approved these changes
Jan 14, 2025
RamOrkes
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DynamicForkTaskin its current state is non-functional. It requires a "pre_fork_task" and the dynamic tasks and their inputs are supposed to be taken from its output.It's not working and it's too rigid. It won't allow using an INLINE task (given how this task outputs the result), it won't allow setting the dynamic tasks and inputs in the task def itself, or take it from a workflow input.
TODO (in an upcoming PR)
NOTES