Adds watched schools #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 6793264 | Generic High Entropy Secret | c6fa2d3 | features/schools/get_schools.http | View secret |
| 6793264 | Generic High Entropy Secret | c6fa2d3 | features/schools/get_schools.http | View secret |
| 6793264 | Generic High Entropy Secret | c6fa2d3 | features/schools/get_schools.http | View secret |
| 6793264 | Generic High Entropy Secret | c6fa2d3 | features/schools/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | c6fa2d3 | features/schools/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | c6fa2d3 | features/schools/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | c6fa2d3 | features/schools/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | e9e5b8a | features/schools/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | e9e5b8a | features/schools/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | c46a7b1 | features/schools/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | 570d26b | features/admin/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | 570d26b | features/votes/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | 570d26b | features/auth/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | 570d26b | features/posts/requests.http | View secret |
| 6793264 | Generic High Entropy Secret | 570d26b | features/schools/requests.http | View secret |
| 7045040 | Company Email Password | 570d26b | features/auth/requests.http | View secret |
| 7062930 | Bearer Token | 570d26b | features/posts/requests.http | View secret |
| 7062930 | Bearer Token | 570d26b | features/votes/requests.http | View secret |
| 7085662 | Bearer Token | 570d26b | features/schools/requests.http | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
hn275
suggested changes
Jun 19, 2023
| } | ||
|
|
||
| // TODO: should this be limited to only N schools? Paginated? Or | ||
| // TODO: will this be cached locally so we'd want to get everything? |
There was a problem hiding this comment.
could you create a ticket for this and reference it here?
Otherwise this would be the last time we see these lines of comments and never get to it lol
features/schools/unwatch_school.go
Outdated
Comment on lines
32
to
38
| // create validator | ||
| validator := validator.New() | ||
|
|
||
| binding := &validation.DefaultBinding{ | ||
| Validator: validator, | ||
| } | ||
| if err := binding.Bind(c.Request, &req); err != nil { |
There was a problem hiding this comment.
my previous pr mentioned putting this in a function, will drop a +1 on where this would be beneficial to use that function
features/schools/watch_school.go
Outdated
Comment on lines
49
to
54
| validator := validator.New() | ||
|
|
||
| binding := &validation.DefaultBinding{ | ||
| Validator: validator, | ||
| } | ||
| if err := binding.Bind(c.Request, &req); err != nil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
POST /schools/watchto watch a new school.DELETE /schools/unwatchto unwatch a school.GET /schools/watchedto see all of a user's watched schools.Notes