fix: Add missing body close calls after reading from request

Signed-off-by: jay-dee7 <[email protected]>
containerish · Dec 7, 2023 · 0d89fdc · 0d89fdc
1 parent b0bf038
commit 0d89fdc
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/auth/server/webauthn_server.go b/auth/server/webauthn_server.go
@@ -348,6 +348,10 @@ func (wa *webauthn_server) BeginLogin(ctx echo.Context) error {
 		},
 	}
 
+	defer func() {
+		ctx.Request().Body.Close()
+	}()
+
 	credentialAssertion, err := wa.webauthn.BeginLogin(ctx.Request().Context(), opts)
 	if err != nil {
 		if werr := wa.webauthn.RemoveSessionData(ctx.Request().Context(), user.ID); werr != nil {
@@ -366,7 +370,6 @@ func (wa *webauthn_server) BeginLogin(ctx echo.Context) error {
 		wa.logger.Log(ctx, err).Send()
 		return echoErr
 	}
-	defer ctx.Request().Body.Close()
 
 	echoErr := ctx.JSON(http.StatusOK, echo.Map{
 		"options": credentialAssertion,

diff --git a/auth/signup.go b/auth/signup.go
@@ -19,7 +19,7 @@ import (
 func (a *auth) parseSignUpRequest(ctx echo.Context) (*types.User, error) {
 	var user types.User
 	if err := json.NewDecoder(ctx.Request().Body).Decode(&user); err != nil {
-		return nil, err
+		return nil, fmt.Errorf("error parsing signup request: %w", err)
 	}
 	defer ctx.Request().Body.Close()
 

diff --git a/orgmode/admin.go b/orgmode/admin.go
@@ -35,6 +35,7 @@ func (o *orgMode) AllowOrgAdmin() echo.MiddlewareFunc {
 					o.logger.Log(ctx, err).Send()
 					return echoErr
 				}
+				defer ctx.Request().Body.Close()
 
 				// only allow self-migrate
 				if !strings.EqualFold(user.ID.String(), body.UserID.String()) {

diff --git a/registry/v2/repository.go b/registry/v2/repository.go
@@ -36,6 +36,7 @@ func (r *registry) CreateRepository(ctx echo.Context) error {
 			"message": "error parsing request input",
 		})
 	}
+	defer ctx.Request().Body.Close()
 
 	if err = body.Validate(); err != nil {
 		return ctx.JSON(http.StatusBadRequest, echo.Map{