Fix #3302: debounce sidebar rendering #3303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnXLivingston
force-pushed
the
fix_3302_debounce_muc_sidebar_rendering
branch
from
c8de048 to
11ad2f9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@jcbrand , we discussed on ConverseJS chat room about another issue: when users change their nicknames, the MUC participant user list does not refresh (the sorting is not updated). I added it in this PR, as the code is not the same on master. Tell me if you prefer that i remove this commit, and make another PR. |
|
Hi @jcbrand . I was trying to fix the tests. Last CI run fails on errors in styling.js. I have the same issue on my laptop, can't figure out why. On my laptop it fails here: What i got: Go to ~<a target="_blank" rel="noopener" href="https://conversejs.org~now/">https://conversejs.org~now</a> <span class="styling-directive">_</span><i>please</i><span class="styling-directive">_</span>There is a "a" tag, despite the test suite does not expect it. Seems not related to this PR. |
|
Thanks, merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the fix i propose to #3302
Not sure it is acceptable for you upstream (as it fixes a non-standard use case), just let me know.