Trying to fix two headless instances being in build #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jcbrand
force-pushed
the
jcbrand/fix-two-instances-headless
branch
3 times, most recently
from
396cafa to
f7dafb5
Compare
Refactored so that all imports from `@converse/headless` are from the index and not deeper files. Updates #3348
Remove the `browser` entry in the headless package.json, otherwise the headless build (in src/headless/dist) is used when building converse.js, which tries to load a different emojis.json
jcbrand
force-pushed
the
jcbrand/fix-two-instances-headless
branch
from
4485956 to
3e96a46
Compare
jcbrand
force-pushed
the
jcbrand/fix-two-instances-headless
branch
from
f47a7dc to
41995f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.