Prevent duplication of text avatar into display name

[BetaRays]

Fixes #3529.

• Add a changelog entry for your change in CHANGES.md
• When adding a configuration variable, please make sure to
  document it in docs/source/configuration.rst
• Please add a test for your change. Tests can be run in the commandline
  with make check or you can run them in the browser by running make serve
  and then opening http://localhost:8000/tests.html.

[BetaRays]

I tried making a test for it, but I’m not sure how to wait until the name has been updated, if it’s supposed to not change.

[BetaRays]

Also, I’m not sure if adding an entry to the changelog is necessary here if the bug didn’t appear in the previous version (or any released version). (The bug is also triggered by unread indicators.)

[jcbrand]

I tried making a test for it, but I’m not sure how to wait until the name has been updated, if it’s supposed to not change.

Maybe just look for an existing test in the roomslist plugin and add a check that the name stays the same when clicking on the item in the list to open a room.

[BetaRays]

I tried making a test for it, but I’m not sure how to wait until the name has been updated, if it’s supposed to not change.

Maybe just look for an existing test in the roomslist plugin and add a check that the name stays the same when clicking on the item in the list to open a room.

My issue is that I need to put some kind of delay between clicking and checking for the new name (otherwise the test passes when it shouldn’t because the name hasn’t been updated yet): this is usually done with u.waitUntil but I’m not sure what condition to use (waiting for the name to change would fail if it stays the same as it’s supposed to).

[jcbrand]

My issue is that I need to put some kind of delay between clicking and checking for the new name (otherwise the test passes when it shouldn’t because the name hasn’t been updated yet): this is usually done with u.waitUntil but I’m not sure what condition to use (waiting for the name to change would fail if it stays the same as it’s supposed to).

You could set a different name before clicking and then checking that it is set back to the right name, but I don't think a test is that important in this case, so I'll merge.