Refactor add-muc modal #3586
Merged
Refactor add-muc modal #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `id` attr of the xmpp-status obj gets passed in when opening a chat with our own JID, which causes problems because the JID should be the `id`.
- Escape JID before creating a new MUC
- Allow adding/entering a MUC by specifying only a name
If no MUC service is provided, we fetch the default service and use that.
- Add validation for the MUC name/jid
- Add test for the muc_roomid_policy setting
- Create normalized MUC JID when only a name is provided
jcbrand
force-pushed
the
jcbrand/refactor-add-muc-modal
branch
from
8234206 to
68243ab
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jcbrand
force-pushed
the
jcbrand/refactor-add-muc-modal
branch
from
68243ab to
f624fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.