tests: the decorator and the controller are covered

I've also adapted the tests of members and offers decorators. Issue #596.

app/decorators/report/detailed_decorator.rb

@@ -7,9 +7,9 @@ def initialize(org)
 
   def name(extension)
     "#{@org.name.parameterize}_"\
-    "#{Date.today}."\
     "#{I18n.t('global.detailed')}_"\
-    ".#{extension}"
+    "#{Date.today}."\
+    "#{extension}"
   end
 
   def headers
@@ -76,7 +76,7 @@ def post_headers
   end
 
   def post_rows
-    make_rows(Post, %w[tsv], @org.posts.map)
+    make_rows(Post, %w[tsv], @org.posts)
   end
 
   def transfer_headers

spec/controllers/reports_controller_spec.rb

@@ -90,6 +90,16 @@
       end
     end
 
+    describe 'GET #download_csv_detailed' do
+      it 'downloads a CSV' do
+        get :download_csv_detailed
+        report = Report::Csv::Detailed.new(test_organization)
+
+        expect(response.body).to eq(report.run)
+        expect(response.media_type).to eq("text/csv")
+      end
+    end
+
     describe 'GET #download_all' do
       it 'downloads a zip' do
         get :download_all
@@ -99,6 +109,7 @@
         expect(response.body).to include('Offers')
         expect(response.body).to include('Members')
         expect(response.body).to include('Transfers')
+        expect(response.body).to include('Detaileds')
       end
 
       it 'redirects to download_all_report_path (retry) if zip is not ready' do

spec/decorators/report/member_decorator_spec.rb

@@ -22,8 +22,6 @@
       User.human_attribute_name(:alt_phone),
       User.human_attribute_name(:created_at),
       User.human_attribute_name(:last_sign_in_at),
-      User.human_attribute_name(:locale),
-      Account.human_attribute_name(:balance)
     ])
   end
 
@@ -37,8 +35,6 @@
         member.user.alt_phone,
         member.user.created_at.to_s,
         member.user.last_sign_in_at.to_s,
-        member.user.locale,
-        member.account_balance.to_s
       ]
     ])
   end

spec/decorators/report/post_decorator_spec.rb

@@ -24,7 +24,6 @@
 
   it "#headers" do
     expect(decorator.headers).to eq([
-      "",
       Offer.model_name.human,
       Post.human_attribute_name(:tag_list),
       User.model_name.human,
@@ -38,7 +37,7 @@
 
     expect(decorator.rows).to eq([
       ["", category.name, "", "", ""],
-      [offer.id, offer.title, offer.tag_list.to_s, "#{offer.user} (#{offer.member_uid})", offer.created_at.to_s]
+      [offer.title, offer.tag_list.to_s, "#{offer.user} (#{offer.member_uid})", offer.created_at.to_s]
     ])
   end
 end