make the copper app buildable from a CopperContext #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this method takes a CopperContext and calls the new function with the context clock and logger
the builder uses the builder pattern and is able to construct an app from the CopperContext or the clock and logger individually
|
I really like the builder pattern, I think this will be pretty intuitive for Rust users. Let's update the other examples and merge the PR! |
|
I updated the rest of the examples and removed the new_with_context! |
gbin
approved these changes
Dec 30, 2024
|
Thank you @hscoelho ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the draft PR to discuss the changes in the issue #135
I have made commits to add both the builder pattern and a "new_with_context" method. I did both because I'm not sure which one is actually better, I like the ergonomics of the builder pattern(and it was nice to write), but I like the simplicity of new_with_context 😅. When it's decided which one it's better, I will remove the other one.
I also updated the balance bot example to use the builder pattern, to show how it's used both in the sim_mode and non sim_mode.
I can update the other examples when the changes are settled.