Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the logging parameters user friendiness #206

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

AS1100K
Copy link
Contributor

@AS1100K AS1100K commented Jan 10, 2025

Fixes #205

Also, I Fixed incorrect documentation for read_configuration_str as it reads from the String not the file 5c9d82

@AS1100K AS1100K force-pushed the issue-205 branch 2 times, most recently from ce568c2 to ddbb203 Compare January 11, 2025 15:31
@AS1100K AS1100K marked this pull request as ready for review January 11, 2025 15:31
@AS1100K AS1100K force-pushed the issue-205 branch 5 times, most recently from a34cf87 to 93abc99 Compare January 12, 2025 05:45
@gbin
Copy link
Collaborator

gbin commented Jan 13, 2025

is this ready to be merged?

@AS1100K
Copy link
Contributor Author

AS1100K commented Jan 13, 2025

Yes

@gbin gbin merged commit 1b6c902 into copper-project:master Jan 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the logging parameters user friendiness by adding some sanity checking
2 participants