[FIX] (CI) rust-cache key and fix audit #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
makeecat
commented
Jan 12, 2025
•
makeecat
commented
- Add matrix.mode in cache key. Default cache key cause conflict when build/release try to save the same cache key.
- Further simplify the CI, test all features directly.
- Addressed dependency security issue of cu29_helpers thanks to cargo audit. Use tempfile instead of tempdir. The tempdir was merged into tempfile and became unmaintained.
gbin
approved these changes
Jan 12, 2025
gbin
reviewed
Jan 12, 2025
.github/workflows/general.yml
Outdated
| @@ -166,3 +104,13 @@ jobs: | |||
| - uses: crate-ci/typos@master | |||
| with: | |||
| config: ./.config/_typos.toml | |||
|
|
|||
| audit: | |||
There was a problem hiding this comment.
That could be done once a week like we mentioned on discord.
makeecat
changed the title
makeecat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.