Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pool cuda support for windows platform #227

Merged
merged 6 commits into from
Jan 18, 2025
Merged

Conversation

makeecat
Copy link
Collaborator

@makeecat makeecat commented Jan 18, 2025

Issue

  1. pool.rs cuda implementation does not build for windows platform in CI (https://github.com/copper-project/copper-rs/actions/runs/12837161641/job/35800273948)
  2. the CI does not reflect non-cuda platform setup for linux/windows platform

Solution

  1. fixed cfg setup in pool.rs
  2. separate CI for non-CUDA and CUDA platforms
  3. set up features for non-CUDA platforms in CI manually to exclude CUDA feature. In the future, we need to check if there are new features being introduced, which we need to add these feature flags into CI for non-CUDA platform.

@makeecat makeecat requested a review from gbin January 18, 2025 03:41
@gbin
Copy link
Collaborator

gbin commented Jan 18, 2025

oh ok, that works for me, thanks @makeecat !

@gbin gbin merged commit 7f40f1f into master Jan 18, 2025
10 checks passed
@gbin gbin deleted the yang/fix/pool_cuda_windows branch January 18, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants