Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cu-consolemon debug pane only active if text_log is true #228

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

AS1100K
Copy link
Contributor

@AS1100K AS1100K commented Jan 19, 2025

This PR makes the following behaviour work:

text_log = True with no cu-consolemon -> dumping in the console like it was doing before
text_log = False -> ONLY structured logging in the main log no text is constructed ever.
text_log = True with cu-consolemon  -> redirect that to the Pane
text_log = False with cu-consolemon  -> by order of preference: message in the Pane, no pane or empty Pane it there is no way to know
compilation in release mode -> text_log = False is forced, I would even compile out the support like I did for the standard console version

As discussed on discord

as well as also add time to the log shown in cu-consolemon

@AS1100K AS1100K marked this pull request as draft January 19, 2025 12:22
@AS1100K AS1100K marked this pull request as ready for review January 19, 2025 13:30
@gbin gbin merged commit 5345980 into copper-project:master Jan 20, 2025
10 checks passed
@gbin
Copy link
Collaborator

gbin commented Jan 20, 2025

Thanks

@gbin
Copy link
Collaborator

gbin commented Jan 20, 2025

image
Minor bug: it looks like it doesn't fully clean the screen (you see a some characters remaining from the neofetch)

@AS1100K AS1100K deleted the fix-cumon branch January 21, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants