cleanup(EM): delegated tasks are executable sentences #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an opaque proof contained as Skip (i.e. a syntax error) it was not delegated anyway by the scehduler
|
If I remember correctly, the opener and closer referred to the first proof step. This often lead us to not treat the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an opaque proof contained as Skip (i.e. a syntax error) it was not delegated anyway by the scehduler.
I'm rebasing #915 on top of this one since it makes is much cleaner.
@rtetley please have a look at the code for
id_of_first/last_task. I think my new code is equivalent, but I don't get in which cases the default would be different than the computed one.