Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typographical errors and incorrect usage of articles #4348

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix typographical errors and incorrect usage of articles #4348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8235bd6
typos README.md
Dimitrolito Dec 17, 2024
28f2de9
typos ToSecureUITransportSender.ts
Dimitrolito Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ _If you run into issues with builds try running `yarn clean` and then start agai
<details>
<summary>Seeing `WebSocket connection to 'wss://localhost:9997/ws' failed` error messages in your console?</summary>

You need to install a SSL certificate for localhost as the one provided by [webpack-dev-server is considered invalid](https://github.com/webpack/webpack-dev-server/issues/2957). This step is optional as `react-refresh` will still function without it, but it's a good idea to try and fix this error because otherwise your browser will be making a lot of failed requests and `webpack-dev-server` might not be functioning to its full capabilities.
You need to install an SSL certificate for localhost as the one provided by [webpack-dev-server is considered invalid](https://github.com/webpack/webpack-dev-server/issues/2957). This step is optional as `react-refresh` will still function without it, but it's a good idea to try and fix this error because otherwise your browser will be making a lot of failed requests and `webpack-dev-server` might not be functioning to its full capabilities.

A relatively simple way of doing this is using [mkcert](https://github.com/FiloSottile/mkcert)

Expand Down
2 changes: 1 addition & 1 deletion packages/secure-background/src/transports/ToSecureUITransportSender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import type {

const logger = getLogger("secure-ui ToSecureUITransportSender");

// Forwarder does not set its own origin and instead expects a origin to exist on the request.
// Forwarder does not set its own origin and instead expects an origin to exist on the request.
export class ToSecureUITransportSender<
X extends SECURE_EVENTS,
R extends SecureRequestType = undefined
Expand Down