Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] version should be handled by sbt-dynver #10

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

m-kalai
Copy link
Collaborator

@m-kalai m-kalai commented Dec 20, 2024

Description

Summarize the changes and the related issue. Include relevant motivation and context.

Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

How Has This Been Tested?

Describe how the changes were tested.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@m-kalai m-kalai requested a review from a team as a code owner December 20, 2024 17:47
rtimush
rtimush previously approved these changes Dec 20, 2024
@rtimush rtimush dismissed their stale review December 20, 2024 18:25

sbt ci-release will be called on master branch with a non-snapshot version. Are you confident that it will still publish it properly as a snapshot?

@m-kalai
Copy link
Collaborator Author

m-kalai commented Dec 20, 2024

@rtimush i can't say i'm sure, this is the part i can't test that well, but based on examples i studied and what sbt-ci-release plugin claims it should:

  • git tag pushes are published as regular releases to Maven Central
  • merge into main commits are published as -SNAPSHOT with a unique version number for every commit

@m-kalai m-kalai requested a review from rtimush December 20, 2024 20:17
Copy link
Contributor

@rtimush rtimush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try then

@m-kalai m-kalai merged commit db6af52 into master Dec 20, 2024
5 checks passed
@m-kalai m-kalai deleted the fix/version-by-dynver branch December 20, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants