patch - fixing nil pointer bug in alerts (#221)

* patch - fixing nil pointer bug in alerts

CHANGELOG.md

@@ -522,4 +522,9 @@ New Features:
 ## Release 1.13.1
 Bug fixing:
 #### resource/coralogix_dashboard
-* adding schema upgrade v1 to v2 (for `annotations.source.metrics` field).
+* adding schema upgrade v1 to v2 (for `annotations.source.metrics` field).
+
+## Release 1.13.2
+Bug fixing:
+#### resource/coralogix_alert
+* fixing [runtime error: invalid memory address or nil pointer dereference](https://github.com/coralogix/terraform-provider-coralogix/issues/212).

coralogix/resource_coralogix_alert.go

@@ -1547,10 +1547,16 @@ func extractCreateAlertRequest(d *schema.ResourceData) (*alerts.CreateAlertReque
 	incidentSettings := expandIncidentSettings(d.Get("incident_settings"))
 	notificationGroups, dgs := expandNotificationGroups(d.Get("notifications_group"))
 	diags = append(diags, dgs...)
+	if len(diags) != 0 {
+		return nil, diags
+	}
 	payloadFilters := expandPayloadFilters(d.Get("payload_filters"))
 	scheduling := expandActiveWhen(d.Get("scheduling"))
 	alertTypeParams, tracingAlert, dgs := expandAlertType(d)
 	diags = append(diags, dgs...)
+	if len(diags) != 0 {
+		return nil, diags
+	}
 
 	return &alerts.CreateAlertRequest{
 		Name:                       name,

coralogix/resource_coralogix_alert_test.go

@@ -108,13 +108,15 @@ func TestAccCoralogixResourceAlert_newValue(t *testing.T) {
 		keyToTrack:            "EventType",
 		timeWindow:            selectRandomlyFromSlice(alertValidNewValueTimeFrames),
 	}
+	alert.notifyOn = "Triggered_only"
 	checks := extractNewValueChecks(alert)
 
 	updatedAlert := newValueAlertTestParams{
 		alertCommonTestParams: *getRandomAlert(),
 		keyToTrack:            "EventType",
 		timeWindow:            selectRandomlyFromSlice(alertValidNewValueTimeFrames),
 	}
+	updatedAlert.notifyOn = "Triggered_only"
 	updatedAlertChecks := extractNewValueChecks(updatedAlert)
 
 	resource.Test(t, resource.TestCase{
@@ -359,7 +361,7 @@ func TestAccCoralogixResourceAlert_flow(t *testing.T) {
 		severity:        selectRandomlyFromSlice(alertValidSeverities),
 		activeWhen:      randActiveWhen(),
 		notifyEveryMin:  acctest.RandIntRange(1500 /*to avoid notify_every < condition.0.time_window*/, 3600),
-		notifyOn:        selectRandomlyFromSlice(validNotifyOn),
+		notifyOn:        "Triggered_only",
 	}
 	checks := extractFlowAlertChecks(alert)
 
@@ -371,7 +373,7 @@ func TestAccCoralogixResourceAlert_flow(t *testing.T) {
 		severity:        selectRandomlyFromSlice(alertValidSeverities),
 		activeWhen:      randActiveWhen(),
 		notifyEveryMin:  acctest.RandIntRange(1500 /*to avoid notify_every < condition.0.time_window*/, 3600),
-		notifyOn:        selectRandomlyFromSlice(validNotifyOn),
+		notifyOn:        "Triggered_only",
 	}
 	updatedAlertChecks := extractFlowAlertChecks(updatedAlert)