Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump SDK version and pass domain to the SDK instead of full URL when … #312

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Bump SDK version and pass domain to the SDK instead of full URL when … #312

merged 1 commit into from
Jan 27, 2025

Conversation

lootag
Copy link
Contributor

@lootag lootag commented Jan 27, 2025

…CORALOGIX_DOMAIN is used instead of CORALOGIX_ENV

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@lootag
Bump SDK version and pass domain to the SDK instead of full URL when …
9570622 
…CORALOGIX_DOMAIN is used instead of CORALOGIX_ENV
@lootag lootag requested a review from a team as a code owner January 27, 2025 16:11
@lootag lootag merged commit 88b34e8 into master Jan 27, 2025
6 of 7 checks passed
@lootag lootag deleted the IAC-443 branch January 27, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShauliSolomovich ShauliSolomovich ShauliSolomovich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lootag @ShauliSolomovich