Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

Adds the ability to download an Ignition config #233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AltMeta
Copy link

@AltMeta AltMeta commented Mar 29, 2017

No description provided.

@crawford
Copy link
Contributor

I'm not sure this buys us much. This can already be done within Ignition directly using replace.

@AltMeta
Copy link
Author

AltMeta commented Mar 29, 2017

Thanks for getting back to me so quick.

The replace directive allows a remote ignition config to be run.
However a config with this directive needs to be present prior to executing coreos-install.

In the instance you're installing from bare metal from the coreos_production_iso_image,
you either have to download the config, run coreos-install with this path or rebuild the iso with an ignition config present.

This will allow us to run:
coreos-install -d /dev/sda -i http://example.con/ignition.json

Sure it doesn't buy much, but it doesn't cost much either.

@@ -344,10 +344,20 @@ if [[ -n "${CLOUDINIT}" ]]; then
fi

if [[ -n "${IGNITION}" ]]; then

if [[ "${IGNITION:4:3}" == "://" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we match against http(s)? instead? We wouldn't want to attempt this, for example, with gs:// URLs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this should now only match http(s)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants