This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
vmware: private key variable #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
squat
reviewed
Jun 21, 2017
modules/vmware/node/variables.tf
Outdated
|
|
||
| variable "private_key" { | ||
| type = "string" | ||
| description = "SSH private key file corresponding to tectonic_vmware_ssh_authorized_key. If not provided, SSH agent will be used." |
There was a problem hiding this comment.
thanks @squat , updated
|
@squat can I get another review when you have a moment. |
|
@alekssaul sorry about this, but this needs a rebase now. |
|
ok to test |
alekssaul
added a commit
to alekssaul/tectonic-installer
that referenced
this pull request
Jul 11, 2017
* vmware: private key variable * modules/vmware: update private_key description
alekssaul
added a commit
to alekssaul/tectonic-installer
that referenced
this pull request
Jul 11, 2017
* vmware: private key variable * modules/vmware: update private_key description
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #995 broke the master for vmware. This is my fault with bad testing :(
VMware module was referencing
tectonic_vmware_ssh_private_key_pathvariable that exists in platform/variables.tf but not known to individual module. This pr passestectonic_vmware_ssh_private_key_pathto VMware module.