Schedule API Adjustments #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schedule API: schedule.py - get_schedule(date) no longer has an optional parameter 'date'. This is now a required parameter. This method now will reduce down the response payload to only the games for the supplied date. This is a change from the old way. Old functionality has been moved to 'get_weekly_schedule' - get_weekly_schedule(date?) has been added to return the weekly games, for the week of the supplied date. Data is still optional but defaults to the NHL interrepation of 'now' or 'today'. - Adds new tests to cover functionality in these updated schedule endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schedule API: schedule.py
get_schedule(date) no longer has an optional parameter 'date'. This is now a required parameter. This method now will reduce down the response payload to only the games for the supplied date. This is a change from the old way. Old functionality has been moved to 'get_weekly_schedule'
get_weekly_schedule(date?) has been added to return the weekly games, for the week of the supplied date. Data is still optional but defaults to the NHL interrepation of 'now' or 'today'.
Adds new tests to cover functionality in these updated schedule endpoints
closes #70