Set page to undefined when selected page is not greater than 0

https://coveord.atlassian.net/browse/KIT-3462
coveo · Dec 12, 2024 · 10c36aa · 10c36aa
1 parent 91968fe
commit 10c36aa
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 11 deletions.
diff --git a/packages/headless/src/features/commerce/parameters/parameters-slice.test.ts b/packages/headless/src/features/commerce/parameters/parameters-slice.test.ts
@@ -106,9 +106,9 @@ describe('commerceParameters slice', () => {
         expect(finalState).toEqual({...state, page: 1});
       });
 
-      it('when state.page is undefined, set state.page to 0', () => {
+      it('when state.page is undefined, set state.page to undefined', () => {
         const finalState = parametersReducer(initialState, previousPage());
-        expect(finalState).toEqual({...initialState, page: 0});
+        expect(finalState).toEqual({...initialState, page: undefined});
       });
     });
   });
@@ -126,13 +126,24 @@ describe('commerceParameters slice', () => {
       expect(finalState).toEqual(state);
     });
 
-    it('when payload.slotId is not defined, sets state.page to payload.page', () => {
-      const state = {
-        ...initialState,
-        page: 1,
-      };
-      const finalState = parametersReducer(state, selectPage({page: 5}));
-      expect(finalState).toEqual({...state, page: 5});
+    describe('when payload.slotId is not defined', () => {
+      it('when state.page is greater than 0, sets state.page to payload.page', () => {
+        const state = {
+          ...initialState,
+          page: 1,
+        };
+        const finalState = parametersReducer(state, selectPage({page: 5}));
+        expect(finalState).toEqual({...state, page: 5});
+      });
+
+      it('when state.page is not greater than 0, sets state.page to undefined', () => {
+        const state = {
+          ...initialState,
+          page: 1,
+        };
+        const finalState = parametersReducer(state, selectPage({page: 0}));
+        expect(finalState).toEqual({...state, page: undefined});
+      });
     });
   });
 

diff --git a/packages/headless/src/features/commerce/parameters/parameters-slice.ts b/packages/headless/src/features/commerce/parameters/parameters-slice.ts
@@ -182,7 +182,7 @@ const handlePreviousPage = (
     return;
   }
 
-  state.page = 0;
+  state.page = undefined;
 };
 
 const handleSelectPage = (
@@ -193,7 +193,7 @@ const handleSelectPage = (
     return;
   }
 
-  state.page = payload.page;
+  state.page = payload.page > 0 ? payload.page : undefined;
 };
 
 const handleSetPageSize = (