put productId as ?undefined

https://coveord.atlassian.net/browse/KIT-3801
coveo · Dec 19, 2024 · 4e9dfaa · 4e9dfaa
1 parent 1445716
commit 4e9dfaa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/packages/headless/src/controllers/commerce/recommendations/headless-recommendations.ts b/packages/headless/src/controllers/commerce/recommendations/headless-recommendations.ts
@@ -84,7 +84,7 @@ export interface RecommendationsState {
   error: CommerceAPIErrorStatusResponse | null;
   isLoading: boolean;
   responseId: string;
-  productId: string;
+  productId?: string;
 }
 
 export interface RecommendationsOptions {

diff --git a/packages/headless/src/features/commerce/recommendations/recommendations-slice.ts b/packages/headless/src/features/commerce/recommendations/recommendations-slice.ts
@@ -38,9 +38,7 @@ export const recommendationsReducer = createReducer(
           return;
         }
 
-        state[slotId] = buildRecommendationsSlice(
-          productId ? {productId} : undefined
-        );
+        state[slotId] = buildRecommendationsSlice({productId});
       })
       .addCase(fetchRecommendations.rejected, (state, action) => {
         handleError(state, action.meta.arg.slotId, action.payload);

diff --git a/packages/headless/src/features/commerce/recommendations/recommendations-state.ts b/packages/headless/src/features/commerce/recommendations/recommendations-state.ts
@@ -7,7 +7,7 @@ export interface RecommendationsSlice {
   isLoading: boolean;
   responseId: string;
   products: Product[];
-  productId: string;
+  productId?: string;
 }
 
 /**
@@ -26,5 +26,5 @@ export const getRecommendationsSliceInitialState =
     isLoading: false,
     responseId: '',
     products: [],
-    productId: '',
+    productId: undefined,
   });