fix(headless commerce): do not set query to empty string when buildin…

…g non field suggestions facet search requests (#4860) https://coveord.atlassian.net/browse/KIT-3857
coveo · Jan 20, 2025 · ddf5664 · ddf5664
1 parent 240f26e
commit ddf5664
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/...e/facets/facet-search-set/category/commerce-category-facet-search-request-builder.test.ts b/...e/facets/facet-search-set/category/commerce-category-facet-search-request-builder.test.ts
@@ -29,6 +29,8 @@ describe('#buildCategoryFacetSearchRequest', () => {
     query = 'test';
     state = buildMockCommerceState();
 
+    state.commerceQuery.query = 'test query';
+
     state.categoryFacetSearchSet[facetId] = buildMockCategoryFacetSearch({
       options: {...buildMockFacetSearchRequestOptions(), query},
     });
@@ -186,7 +188,7 @@ describe('#buildCategoryFacetSearchRequest', () => {
       facetId,
       facetQuery: `*${query}*`,
       ignorePaths: [],
-      query: state.commerceQuery?.query,
+      query: 'test query',
     });
   });
 
@@ -206,7 +208,7 @@ describe('#buildCategoryFacetSearchRequest', () => {
       facetId,
       facetQuery: `*${query}*`,
       ignorePaths: [],
-      query: '',
+      query: 'test query',
     });
   });
 });
diff --git a/...mmerce/facets/facet-search-set/category/commerce-category-facet-search-request-builder.ts b/...mmerce/facets/facet-search-set/category/commerce-category-facet-search-request-builder.ts
@@ -54,7 +54,7 @@ export const buildCategoryFacetSearchRequest = (
     clientId,
     context,
     query,
-    ...(!isFieldSuggestionsRequest && {...restOfCommerceAPIRequest, query: ''}),
+    ...(!isFieldSuggestionsRequest && {...restOfCommerceAPIRequest}),
   };
 };
 

diff --git a/...rce/facets/facet-search-set/regular/commerce-regular-facet-search-request-builder.test.ts b/...rce/facets/facet-search-set/regular/commerce-regular-facet-search-request-builder.test.ts
@@ -21,6 +21,7 @@ describe('#buildFacetSearchRequest', () => {
     facetId = '1';
     query = 'test';
     state = buildMockCommerceState();
+    state.commerceQuery.query = 'test query';
     state.facetSearchSet[facetId] = buildMockFacetSearch({
       options: {...buildMockFacetSearchRequestOptions(), query},
     });
@@ -71,7 +72,7 @@ describe('#buildFacetSearchRequest', () => {
       ...buildCommerceAPIRequestMock.mock.results[0].value,
       facetId,
       facetQuery: `*${query}*`,
-      query: state.commerceQuery?.query,
+      query: 'test query',
     });
   });
 
@@ -89,7 +90,7 @@ describe('#buildFacetSearchRequest', () => {
     expect(request).toEqual({
       ...expectedBaseRequest,
       facetId,
-      query: '',
+      query: 'test query',
       facetQuery: `*${query}*`,
     });
   });

diff --git a/...commerce/facets/facet-search-set/regular/commerce-regular-facet-search-request-builder.ts b/...commerce/facets/facet-search-set/regular/commerce-regular-facet-search-request-builder.ts
@@ -40,6 +40,6 @@ export const buildFacetSearchRequest = (
     clientId,
     context,
     query,
-    ...(!isFieldSuggestionsRequest && {...restOfCommerceAPIRequest, query: ''}),
+    ...(!isFieldSuggestionsRequest && {...restOfCommerceAPIRequest}),
   };
 };