fix(commerce): forward required display name (#3490)

forward required display name
coveo · Dec 15, 2023 · fdc2c60 · fdc2c60
1 parent 1ec9ff8
commit fdc2c60
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/packages/headless/src/features/commerce/facets/facet-set/facet-set-selector.ts b/packages/headless/src/features/commerce/facets/facet-set/facet-set-selector.ts
@@ -1,5 +1,6 @@
 import {
   CommerceFacetSetSection,
+  CommerceSearchSection,
   ProductListingV2Section,
 } from '../../../../state/state-sections';
 import {AnyFacetResponse} from './interfaces/response';
@@ -12,7 +13,7 @@ function isFacetResponse(
 }
 
 function baseCommerceFacetResponseSelector(
-  state: ProductListingV2Section,
+  state: ProductListingV2Section | CommerceSearchSection,
   facetId: string
 ) {
   const findById = (response: {facetId: string}) =>
@@ -22,11 +23,16 @@ function baseCommerceFacetResponseSelector(
     return state.productListing.facets.find(findById);
   }
 
+  if ('commerceSearch' in state) {
+    return state.commerceSearch.facets.find(findById);
+  }
+
   return undefined;
 }
 
 export const commerceFacetResponseSelector = (
-  state: ProductListingV2Section & CommerceFacetSetSection,
+  state: (ProductListingV2Section | CommerceSearchSection) &
+    CommerceFacetSetSection,
   facetId: string
 ) => {
   const response = baseCommerceFacetResponseSelector(state, facetId);
@@ -38,11 +44,15 @@ export const commerceFacetResponseSelector = (
 };
 
 export const isCommerceFacetLoadingResponseSelector = (
-  state: ProductListingV2Section
+  state: ProductListingV2Section | CommerceSearchSection
 ) => {
   if ('productListing' in state) {
     return state.productListing.isLoading;
   }
 
+  if ('commerceSearch' in state) {
+    return state.commerceSearch.isLoading;
+  }
+
   return undefined;
 };
diff --git a/packages/headless/src/features/commerce/facets/facet-set/facet-set-slice.ts b/packages/headless/src/features/commerce/facets/facet-set/facet-set-slice.ts
@@ -255,6 +255,7 @@ function updateStateFromFacetResponse(
   }
 
   facetRequest.facetId = facetId;
+  facetRequest.displayName = facetResponse.displayName;
   facetRequest.numberOfValues = facetResponse.values.length;
   facetRequest.field = facetResponse.field;
   facetRequest.type = facetResponse.type;

diff --git a/packages/headless/src/features/commerce/facets/facet-set/interfaces/request.ts b/packages/headless/src/features/commerce/facets/facet-set/interfaces/request.ts
@@ -10,6 +10,7 @@ export type CommerceFacetRequest = Pick<
   | 'isFieldExpanded'
   | 'preventAutoSelect'
 > & {
+  displayName: string;
   type: FacetType;
   values: AnyFacetValueRequest[];
   initialNumberOfValues: number;

diff --git a/packages/headless/src/test/mock-commerce-facet-request.ts b/packages/headless/src/test/mock-commerce-facet-request.ts
@@ -5,6 +5,7 @@ export function buildMockCommerceFacetRequest(
 ): CommerceFacetRequest {
   return {
     facetId: '',
+    displayName: '',
     field: '',
     type: 'regular',
     numberOfValues: 8,