feat(commerce): atomic-product-field-condition #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #3956 Adds the `atomic-product-field-condition` component to enable conditional rendering based on commerce-specific fields in Coveo's UI Kit. - Implements the component with properties `ifDefined` and `ifNotDefined` to check for the presence or absence of specified fields. - Introduces `mustMatch` and `mustNotMatch` properties for conditional rendering based on matching field values, utilizing `ProductTemplatesHelpers`. - Ensures the component evaluates conditions on component load and removes itself from the DOM if conditions are not met, maintaining clean template structure. - Utilizes `@ProductContext` to access the current product's properties for condition evaluation. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/coveo/ui-kit/issues/3956?shareId=c1d4fa4c-3d58-4aab-a30d-db1259b300e5).
|
Pull Request Report PR Title ❌ Title should follow the conventional commit spec: (optional scope): Example: feat(headless): add result-list controller Bundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support |
|
Introduces the
For more details, open the Copilot Workspace session. |
Introduces the `atomic-product-field-condition` component and implements it in commerce example pages. - Adds the `atomic-product-field-condition` component definition in `components.d.ts`, including properties for verifying if specified fields are defined or not defined. - Implements the `atomic-product-field-condition` component in the `atomic-product-field-condition.tsx` file, with logic to conditionally render content based on product field definitions. - Updates commerce example pages (`homepage.html` and `search.html`) to replace `atomic-field-condition` with the new `atomic-product-field-condition` component for conditional rendering based on product fields. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/coveo/ui-kit/pull/3959?shareId=052a354e-c767-4be7-a8ed-fd0a509dea68).
louis-bompart
changed the title
olamothe
approved these changes
May 17, 2024
y-lakhdar
reviewed
May 21, 2024
...ic/src/components/commerce/atomic-product-field-condition/atomic-product-field-condition.tsx
Show resolved
Hide resolved
y-lakhdar
previously requested changes
May 21, 2024
…ondition/atomic-product-field-condition.tsx Co-authored-by: ylakhdar <[email protected]>
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Error
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
force-pushed
the
louis-bompart/add-product-field-condition-1
branch
from
913d1b8 to
565c1dd
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
force-pushed
the
louis-bompart/add-product-field-condition-1
branch
from
565c1dd to
7068d88
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3956
Adds the
atomic-product-field-conditioncomponent to enable conditional rendering based on commerce-specific fields in Coveo's UI Kit.ifDefinedandifNotDefinedto check for the presence or absence of specified fields.mustMatchandmustNotMatchproperties for conditional rendering based on matching field values, utilizingProductTemplatesHelpers.@ProductContextto access the current product's properties for condition evaluation.KIT-3058
For more details, open the Copilot Workspace session.