-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add deprecation note for DNT #4020
Conversation
Here is what I would propose to try:
When you look at the full logic, calling |
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
Made the changes @olamothe. Removing |
The PR adds a deprecation note to remove DNT as part of the next major release.
The decision is captured here. The main drivers were:
Aside
I tried to adjust the logic in headless to only apply DNT if the analyticsMode is
legacy
. However, this required changing an action to an thunk. The signature change created multiple typescript errors, and so seems like it's breaking. I changed course to add a deprecation note instead. With the v3 release around the corner, it seems less risky to simply remove thedoNotTrack
function rather than making a signature change.