-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhance focus handling for search-box components #4027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I unfortunately don't have an iPhone to test it
packages/atomic/src/components/common/search-box/search-box-wrapper.tsx
Outdated
Show resolved
Hide resolved
a02c070
to
3d25c40
Compare
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on the condition that we can verify this with iPhone simulator first ;)
packages/atomic/src/components/common/search-box/search-box-wrapper.tsx
Outdated
Show resolved
Hide resolved
The verification has been done ish': I did test with the simulator, but I suspect it didn't test and that there's no way to actually test the behaviour of KIT-1941 without an actual physical device. |
f0e0945
to
3a0b10a
Compare
@lvu285 , can you validate KIT-3299, and a round of testing on focus behavior of the Searchboxes? You can use the Storybook link that's here #4027 (comment) and use the Searchbox stories if you prefer :) What I tested so far:
|
It looks ok for me on Storybook, but I'm curious how it would interact with other components too. |
Feel free to checkout the branch and run the examples on your machine (yeah, we'll add'em eventually to the demo links :) baby steps :D ) |
focus
listener and a guard to ensure the newly focused element is not a child of the SearchBoxWrapper main element.https://coveord.atlassian.net/browse/KIT-3299