Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deploy Storybook book demo on PR #4031

Merged
merged 79 commits into from
May 30, 2024
Merged

chore: deploy Storybook book demo on PR #4031

merged 79 commits into from
May 30, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented May 29, 2024 •
edited
Loading

@louis-bompart louis-bompart changed the base branch from master to nx-storybook May 29, 2024 23:50
@louis-bompart louis-bompart reopened this May 29, 2024
@louis-bompart louis-bompart changed the title pr artifacts chore: deploy Storybook on "PR site" May 30, 2024
@louis-bompart louis-bompart changed the title chore: deploy Storybook on "PR site" chore: deploy Storybook book demo on PR May 30, 2024
@louis-bompart louis-bompart marked this pull request as ready for review May 30, 2024 02:18
@louis-bompart louis-bompart requested a review from a team as a code owner May 30, 2024 02:18
@louis-bompart louis-bompart requested review from olamothe, fpbrault and fbeaudoincoveo and removed request for a team May 30, 2024 02:18
@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 202.8 202.8 0
commerce 285.5 285.5 0
search 367.4 367.4 0
insight 347.8 347.8 0
product-listing 262.3 262.3 0
product-recommendation 171.9 171.9 0
recommendation 215.8 215.8 0
ssr 360.3 360.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 7 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@coveo coveo deleted a comment from github-actions bot May 30, 2024
@coveo coveo deleted a comment from github-actions bot May 30, 2024
@louis-bompart louis-bompart reopened this May 30, 2024
@louis-bompart louis-bompart added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@louis-bompart louis-bompart enabled auto-merge May 30, 2024 15:41
@louis-bompart louis-bompart added this pull request to the merge queue May 30, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
@louis-bompart @fbeaudoincoveo
chore: deploy Storybook book demo on PR (#4031)
e1e96e5 
Co-authored-by: GitHub Actions Bot <>
Co-authored-by: Frederic Beaudoin <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@louis-bompart louis-bompart added this pull request to the merge queue May 30, 2024
Merged via the queue into master with commit 0766adb May 30, 2024
86 checks passed
@louis-bompart louis-bompart deleted the pr-artifacts branch May 30, 2024 17:55
fpbrault pushed a commit that referenced this pull request May 31, 2024
@louis-bompart @fbeaudoincoveo @fpbrault
chore: deploy Storybook book demo on PR (#4031)
4683432 
Co-authored-by: GitHub Actions Bot <>
Co-authored-by: Frederic Beaudoin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-bompart @fbeaudoincoveo