Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): reset input range on facet clear #4047

Closed
wants to merge 1 commit into from
Closed

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar requested a review from a team as a code owner June 3, 2024 20:08
@developer-experience-bot
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 202.8 202.8 0
commerce 285.9 285.9 0
search 367.4 367.4 0
insight 347.7 347.7 0
product-listing 262.2 262.2 0
product-recommendation 171.9 171.9 0
recommendation 215.8 215.8 0
ssr 360.2 360.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 7 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Member

@olamothe olamothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Humm so we don't tie the range input to any state at all in Headless for commerce ? Why is that 🤔

That's a bit strange, and why we end up with having to handle a stateful property like this in Atomic.

@y-lakhdar
Copy link
Contributor Author

Humm so we don't tie the range input to any state at all in Headless for commerce ? Why is that 🤔

That's a bit strange, and why we end up with having to handle a stateful property like this in Atomic.

There is already a story about this:
https://coveord.atlassian.net/browse/KIT-3293.

I needed some input on how to handle components that involve multiple controllers.

@y-lakhdar
Copy link
Contributor Author

to b fixed in a different PR
See #4090

@y-lakhdar y-lakhdar closed this Jun 14, 2024
@louis-bompart louis-bompart deleted the KIT-3240 branch August 26, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants