Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(commerce): move atomic-product-field-condition to new directory #4048

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Jun 4, 2024

The atomic-product-field-condition component has been moved to the product-template-components directory to better organize the commerce-related components.

KIT-3058

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 4, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 202.9 202.9 0
commerce 285.9 285.9 0
search 367.4 367.4 0
insight 347.7 347.7 0
product-listing 262.2 262.2 0
product-recommendation 171.9 171.9 0
recommendation 215.8 215.8 0
ssr 360.2 360.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 7 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

The `atomic-product-field-condition` component has been moved to the `product-template-components` directory to better organize the commerce-related components.
@louis-bompart louis-bompart force-pushed the refactor/atomic-product-field-condition branch from 5a7cb3d to ceb5b19 Compare June 4, 2024 06:46
@louis-bompart louis-bompart added this pull request to the merge queue Jun 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024
@louis-bompart louis-bompart added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit 2ede6d1 Jun 5, 2024
87 checks passed
@louis-bompart louis-bompart deleted the refactor/atomic-product-field-condition branch June 5, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants