fix(quantic): issue occurring with result title and quick view in salesforce service console addressed #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(commerce): get clientId from Relay instead of state * refactor(event-protocol-utils): set getClientId method * refactor(headless-commerce): use getVisitorId
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
SimonMilord
approved these changes
Jun 11, 2024
erocheleau
reviewed
Jun 11, 2024
packages/quantic/force-app/main/default/lwc/quanticResultLink/quanticResultLink.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticResultQuickview/quanticResultQuickview.js
Show resolved
Hide resolved
erocheleau
approved these changes
Jun 12, 2024
mmitiche
commented
Jun 12, 2024
packages/quantic/force-app/main/default/lwc/quanticResultLink/quanticResultLink.js
Outdated
Show resolved
Hide resolved
…quanticResultLink.js
mmitiche
commented
Jun 12, 2024
packages/quantic/force-app/main/default/lwc/quanticResultQuickview/quanticResultQuickview.js
Outdated
Show resolved
Hide resolved
…view/quanticResultQuickview.js
fpbrault
pushed a commit
that referenced
this pull request
Jun 12, 2024
…esforce service console addressed (#4078) ## [SFINT-5571](https://coveord.atlassian.net/browse/SFINT-5571) ### The issue: An issue was occurring in the Service Console when trying to open a result or its Quickview: https://github.com/coveo/ui-kit/assets/86681870/7d3048d9-61aa-4e1d-a72c-e79fbf9a6e5e This issue is duo to the Proxy object that Salesforce wraps the result object with, this proxy object is causing issues when the Headless library tries to use the result object. ### The solution: Instead of using `Object.create(this.result)` that we used to use to create a copy of the object and that apparently is no longer useful, I'm now creating a new object after distructuring the result object and this is doing the job preventing the errors from occuring: https://github.com/coveo/ui-kit/assets/86681870/c71ea442-e183-4f04-91af-d2bc8cb71f25 [SFINT-5571]: https://coveord.atlassian.net/browse/SFINT-5571?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Sylvie Allain <[email protected]>
Spuffynism
pushed a commit
that referenced
this pull request
Jun 14, 2024
…esforce service console addressed (#4078) ## [SFINT-5571](https://coveord.atlassian.net/browse/SFINT-5571) ### The issue: An issue was occurring in the Service Console when trying to open a result or its Quickview: https://github.com/coveo/ui-kit/assets/86681870/7d3048d9-61aa-4e1d-a72c-e79fbf9a6e5e This issue is duo to the Proxy object that Salesforce wraps the result object with, this proxy object is causing issues when the Headless library tries to use the result object. ### The solution: Instead of using `Object.create(this.result)` that we used to use to create a copy of the object and that apparently is no longer useful, I'm now creating a new object after distructuring the result object and this is doing the job preventing the errors from occuring: https://github.com/coveo/ui-kit/assets/86681870/c71ea442-e183-4f04-91af-d2bc8cb71f25 [SFINT-5571]: https://coveord.atlassian.net/browse/SFINT-5571?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Sylvie Allain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFINT-5571
The issue:
An issue was occurring in the Service Console when trying to open a result or its Quickview:
Screen.Recording.2024-06-11.at.9.06.46.AM.mov
This issue is duo to the Proxy object that Salesforce wraps the result object with, this proxy object is causing issues when the Headless library tries to use the result object.
The solution:
Instead of using
Object.create(this.result)that we used to use to create a copy of the object and that apparently is no longer useful, I'm now creating a new object after distructuring the result object and this is doing the job preventing the errors from occuring:Screen.Recording.2024-06-11.at.9.08.34.AM.mov