Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(quantic): support e2e testing with LWS and with Locker Service with Playwright #4711

Merged
merged 26 commits into from
Dec 4, 2024

Conversation

mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Nov 25, 2024

SFINT-5796

Summary

This PR adds support for end-to-end (E2E) testing in both Lightning Web Security (LWS) and Locker Service environments. The changes ensure that Playwright tests can run seamlessly across these configurations, improving test coverage and reliability for Quantic components.


Key Changes

  1. Playwright Configuration Updates:

    • Added projects for both LWS-enabled and Locker Service environments.
    • Configured baseURL for each environment using environment variables:
      • Quantic__LWS_enabled_URL for LWS-enabled.
      • Quantic__LWS_disabled_URL for Locker Service.
  2. GitHub Actions Workflow:

    • Updated the e2e Quantic workflow to include Playwright tests.
    • Tests now run automatically in the CI pipeline for both configurations (LWS-enabled and Locker Service), but without using a matrix strategy (This will come next)
  3. Documentation:

    • Updated README with instructions for running Playwright tests locally in both LWS and Locker Service environments.

Testing Instructions

  1. Run the following commands locally to test each configuration:
    • LWS-enabled:
      npx playwright test --project=LWS-enabled
    • Locker Service:
      npx playwright test --project=LWS-disabled

Next Steps

  • Transition to a matrix strategy in the GitHub Actions workflow as the number of Playwright tests increases.
  • Expand test coverage to additional Quantic components for both LWS and Locker Service configurations.

https://github.com/coveo/ui-kit/actions/runs/12043295059?pr=4711
Screenshot 2024-11-27 at 9 16 37 AM

Copy link

github-actions bot commented Nov 25, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.8 242.8 0
commerce 347.7 347.7 0
search 413.9 413.9 0
insight 405 405 0
recommendation 255.1 255.1 0
ssr 407.4 407.4 0
ssr-commerce 362.7 362.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@mmitiche mmitiche added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit 4368ee0 Dec 4, 2024
124 checks passed
@mmitiche mmitiche deleted the SFINT-5796 branch December 4, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants