Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(quantic): playwright tests added for user actions feature #4758

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Dec 3, 2024

SFINT-5626

  • Added E2E playwright tests for the quantic user actions toggle component.
  • Added a new unit test for the quantic user actions toggle component.
  • Updated the Quantic Examples community by having an exampleQuanticUserActionToggle component.

Unit tests for the Quantic User Actions Timeline, Quantic User Actions Session and Quantic User Action has been all previously made.

Screenshot 2024-12-03 at 8 48 07 AM

@mmitiche mmitiche requested a review from a team as a code owner December 3, 2024 13:49
Copy link

github-actions bot commented Dec 3, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.8 242.8 0
commerce 347.7 347.7 0
search 414 414 0
insight 405.1 405.1 0
recommendation 255.1 255.1 0
ssr 407.4 407.4 0
ssr-commerce 362.8 362.8 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Contributor

@SimonMilord SimonMilord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! nothing to say here, everything looks good to me nice job!

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice just 1 question, and 1 suggestion, but not required, you can ignore if you disagree

@mmitiche mmitiche added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@mmitiche mmitiche added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit 53c1c10 Dec 10, 2024
101 checks passed
@mmitiche mmitiche deleted the SFINT-5626 branch December 10, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants