fix(headless commerce SSR): fix react provider hydration logic #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lakhdar
requested review from
olamothe,
fpbrault,
louis-bompart and
fbeaudoincoveo
y-lakhdar
commented
Dec 16, 2024
y-lakhdar
commented
Dec 16, 2024
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fbeaudoincoveo
approved these changes
Dec 16, 2024
alexprudhomme
approved these changes
Dec 16, 2024
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
pushed a commit
that referenced
this pull request
Dec 17, 2024
# Hydration Logic Pass the appropriate object to the `hydrateStaticState` method instead of all the controllers from the static state. # Typing changes ## Clearer engine definition type ### Before 😵💫  ### After (a bit better)  ## Support type completion in provider arguments ### Before 😔  ### After 😀  https://coveord.atlassian.net/browse/KIT-3807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hydration Logic
Pass the appropriate object to the
hydrateStaticStatemethod instead of all the controllers from the static state.Typing changes
Clearer engine definition type
Before 😵💫
After (a bit better)
Support type completion in provider arguments
Before 😔
After 😀
https://coveord.atlassian.net/browse/KIT-3807